Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate non string parameters #24

Merged
merged 9 commits into from
Jun 19, 2022
Merged

Deprecate non string parameters #24

merged 9 commits into from
Jun 19, 2022

Conversation

PabloKowalczyk
Copy link
Member

Q A
Fixed tickets #15

Actually non-list parameters is not deprecated, this is still possible:

<?php

use Crunz\Schedule;

$schedule = new Schedule();
$paramsTest = $schedule->run(
    PHP_BINARY,
    [
        '-v',
        '--ini' => 'value',
    ]
);

but this will trigger deprecation:

<?php

use Crunz\Schedule;

$schedule = new Schedule();
$paramsTest = $schedule->run(
    PHP_BINARY,
    [
        '-v',
        '--ini' => false, // non-string value
    ]
);

@PabloKowalczyk PabloKowalczyk added this to the v3.3 milestone Jun 17, 2022
@PabloKowalczyk PabloKowalczyk force-pushed the depreceate-non-string-parameters branch from 2123320 to dab6711 Compare June 17, 2022 07:33
@PabloKowalczyk PabloKowalczyk changed the title Depreceate non string parameters Deprecate non string parameters Jun 17, 2022
@PabloKowalczyk PabloKowalczyk force-pushed the depreceate-non-string-parameters branch 2 times, most recently from 5d5bd59 to 3eb5c05 Compare June 18, 2022 06:47
@PabloKowalczyk PabloKowalczyk force-pushed the depreceate-non-string-parameters branch from 3eb5c05 to 6f3ebb7 Compare June 19, 2022 10:55
@PabloKowalczyk PabloKowalczyk merged commit 4f996c8 into crunzphp:3.3 Jun 19, 2022
@PabloKowalczyk PabloKowalczyk deleted the depreceate-non-string-parameters branch June 19, 2022 11:02
This was referenced Jun 19, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.3
Development

Successfully merging this pull request may close these issues.
1 participant
@PabloKowalczyk